Ticket #80 (closed enhancement: fixed)
Incoming call screen should have a "Silent" button
| Reported by: | Thor | Owned by: | dos |
|---|---|---|---|
| Priority: | trivial | Milestone: | |
| Component: | libframeworkd-phonegui-efl | Version: | |
| Keywords: | Cc: |
Description
A really useful thing to have on the incoming call screen besides Answer and Reject would be a Silent button that would turn off the ringtone and also the vibration.
Attachments
-
patch.diff
(14.1 KB) -
added by albacore 4 years ago.
-
patch_revised.diff
(20.5 KB) -
added by albacore 4 years ago.
Change History
comment:2 Changed 4 years ago by Thor
A use case scenario would be that simply I do not want to answer the call, pretending that I'm asleep or not in the room, and I would not want it to annoy me for ever by ringing constantly. Another use would be that you are in a meeting, library, or other place where you can disturb other people, but you can get out and talk, you would silence the phone while going to a place where you can talk, and answer afterwards.
All the Nokia phones have it, and I'm sure most of the others too.
comment:4 Changed 4 years ago by KaZeR
Bump.. Accepting and implementing should be easy, or reject the ticket if you don't like the idea, but at least it could be close..
comment:5 Changed 4 years ago by spaetz
- Owner changed from quickdev to dos
- Status changed from new to assigned
Problem is that the original author of the apps to whom this bug is assigned is missing in action since 80 days and hasn't been online since. I'll assign to dos1 who did some GUI work on the phone apps.
Dos, do you think this should be possible easily?
comment:6 Changed 4 years ago by dos
I don't know if frameworkd has method to do that. If it has - then it will be easy. If it hasn't - then it's upstream issue.
comment:9 Changed 4 years ago by spaetz
This was fixed in commit http://git.shr-project.org/git/?p=shr.git;a=commit;h=c4bf0e5dc0d0a1f59fd1b544a8f91bb24289c80b c4bf0e5dc0d0a based on your patch. Thanks for your contribution albacore.
comment:10 Changed 4 years ago by dos
albacore: it's commited, but:
+ static char * ringtone_name = "/usr/share/sounds/ringtone_ringnroll.wav";
+ static int sound_lenght = 5;
+ static int on_duration = 200;
+ static int off_duration = 800;
Could you change that to read those values from profile? (using opreferencesd) Hardcoding those values is unacceptable :(
Can you please elaborate on the usefulness of this feature request? I see why _Answer_ and _Reject_ are useful. But why would you want to have your phone to continue to ring silently when you already noticed that it rings?