Ticket #978 (closed defect: fixed)
Settings Time with shr-settings fails
| Reported by: | elhennig | Owned by: | Heinervdm |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | shr-settings | Version: | SHR-unstable |
| Keywords: | Cc: |
Description
I cannot set the current time with the date plugin of shr-settings. Following error is shown on the commandline:
date: invalid date '022611092010.10'
Attachments
-
shr_clock.diff
(793 bytes) -
added by mazikeen 3 years ago.
- patch to explicitly call busybox date
Change History
comment:2 Changed 3 years ago by Heinervdm
Because dos doesn't look for this, i just had a look at this.
The problem is, that the date string is in the wrong order...
Format needed for Date is: YYYYMMDDhhmm.ss
And the used string is: MMDDhhmmYYYYY.ss or sth like that.
I will try to fix it.
comment:3 Changed 3 years ago by TAsn
- Owner changed from dos to Heinervdm
- Status changed from new to assigned
comment:4 Changed 3 years ago by TAsn
- Status changed from assigned to closed
- Resolution set to fixed
Committed Heinervdm's patch.
http://git.shr-project.org/git/?p=shr-settings.git;a=commit;h=f3193a55078460c81f1b62a215ec577ed24fa462
comment:5 Changed 3 years ago by spaetz
- Status changed from closed to reopened
- Resolution fixed deleted
This is in shr-t too.
comment:6 Changed 3 years ago by spaetz
- Status changed from reopened to closed
- Resolution set to fixed
- Milestone set to MS1
comment:7 Changed 3 years ago by mazikeen
- Status changed from closed to reopened
- Resolution fixed deleted
The problem is that 'date' accepts different time formats depending on whether it comes from busybox or from coreutils. With Heinervdm's patch setting the time will work with busybox date but will fail with coreutils date. Since there doesn't seem to be a common date format between the two implementations we need to call the right one. The simple solution is to explicitly call 'busybox date' instead of 'date'.
Changed 3 years ago by mazikeen
-
attachment
shr_clock.diff
added
patch to explicitly call busybox date
comment:8 Changed 3 years ago by Heinervdm
- Status changed from reopened to closed
- Resolution set to fixed in unstable
Ok, thx.
Now it's really fixed: http://git.shr-project.org/git/?p=shr-settings.git;a=commit;h=cf5d1a552bcd879f705b4b237d8936d3c4fd8c5b
comment:9 Changed 3 years ago by jama
- Status changed from closed to reopened
- Resolution fixed in unstable deleted
comment:10 Changed 3 years ago by jama
- Status changed from reopened to closed
- Resolution set to fixed
Closed dupe #992